[Webkit-unassigned] [Bug 35317] [Chromium] Implement WebLabelElement

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35317


Darin Fisher (:fishd, Google) <fishd at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #49346|review?                     |review-
               Flag|                            |




--- Comment #5 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2010-02-23 20:50:44 PST ---
(From update of attachment 49346)
> Index: WebKit/chromium/public/WebLabelElement.h

> +    WebLabelElement(const WebLabelElement& n) : WebElement(n) { }
> +
> +    WebLabelElement& operator=(const WebLabelElement& n)
> +    {
> +        WebElement::assign(n);
> +        return *this;
> +    }
> +
> +    WEBKIT_API void assign(const WebLabelElement& n) { WebElement::assign(n); }

^^^ nit:  s/n/e/ perhaps?  where "e" stands for element, but "n" doesn't seem
to
be related to the type name WebLabelElement.


> +#if WEBKIT_IMPLEMENTATION
> +    WebLabelElement(const WTF::PassRefPtr<WebCore::HTMLLabelElement>&);
> +    WebLabelElement& operator=(const WTF::PassRefPtr<WebCore::HTMLLabelElement>&);
> +    operator WTF::PassRefPtr<WebCore::HTMLLabelElement>() const;
> +#endif
> +
> +    WEBKIT_API WebElement correspondingControl();
> +};

^^^ nit: please put the WEBKIT_IMPLEMENTATION section at the end of the class
to
help make the actual public API a bit more visible.


> Index: WebKit/chromium/src/WebLabelElement.cpp

> +WebLabelElement::WebLabelElement(const WTF::PassRefPtr<HTMLLabelElement>& elem)
> +    : WebElement(elem)
> +{
> +}
> +
> +WebLabelElement& WebLabelElement::operator=(const WTF::PassRefPtr<HTMLLabelElement>& elem)

nit: no need to mention WTF:: since there is a global 'using namespace WTF'

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.