[Webkit-unassigned] [Bug 34631] [Qt] Switching from Phonon to QtMultimedia Backend for Qt 4.7

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34631





--- Comment #37 from Nick Young <nicholas.young at nokia.com>  2010-02-23 16:31:21 PST ---

> I cry foul - no fair casting the "client" pointer to the element so you can use
> it! If there is a problem here you should file a bug and fix it so all ports
> benefit from the change. Is there any reason that MediaPlayer needs to cache
> these values?

To be fair, the caching isn't really the problem. There's a problem related to
supportsMuting() which crops up when you move from a NullMediaPlayerPrivate
(which doesn't support muting) to an actual MediaPlayerPrivate (which does).

It was easier to fix here. But if I get a chance, I'll file a bug and submit a
patch.

> Is it possible for bufferStatus() to return 100 when mediaStatus() does not
> also return QMediaPlayer::BufferedMedia or QMediaPlayer::EndOfMedia? If so,
> why? If not, why do this check here when the condition will be detected in
> updateStates()?

This is here because of an inconsistency with our backends. Fair to say, I
should probably patch the backend and remove this ;)

> Only registerMediaEngine should be public, everything else can be private.

I suppose. I don't really see a problem with it how it is unless it introduces
some sort of security issue..

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.