[Webkit-unassigned] [Bug 35255] [Qt] DRT: Send double click event from EventSender

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35255





--- Comment #5 from Diego Gonzalez <diego.gonzalez at openbossa.org>  2010-02-23 13:35:48 PST ---
(In reply to comment #4)
> (From update of attachment 49319 [details])
> 
> > +    // only consider a click to count, a event which was sent from the
> > +    // same previous button and from the same position
> > +    if (m_currentButton == button && m_mousePos == m_clickPos)
> > +        m_clickCount++;
> > +    else
> > +        m_clickCount = 1;
> 
> Is time difference not supposed to be considered as well? Doesn't Qt already
> handle this?
> 
> > +    QMouseEvent* event;
> > +    if (m_clickCount == 2) {
> > +        event = new QMouseEvent(QEvent::MouseButtonDblClick, m_mousePos,
> > +                        m_mousePos, mouseButton, m_mouseButtons,
> > +                        Qt::NoModifier);
> > +    } else {
> > +        event = new QMouseEvent(QEvent::MouseButtonPress, m_mousePos,
> > +                        m_mousePos, mouseButton, m_mouseButtons,
> > +                        Qt::NoModifier);
> 
> event = new QMouseEvent((m_clickCount == 2) ? QEvent::MouseButtonDblClick :
> QEvent::MouseButtonPress,
>                         m_mousePos, m_mousePos, mouseButton, m_mouseButtons,
> Qt::NoModifier); 
> 
> seems simpler

checking now about time considerations

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.