[Webkit-unassigned] [Bug 34082] [Android] Android Geolocation service should not start if the WebView is paused

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34082





--- Comment #14 from Steve Block <steveblock at google.com>  2010-02-23 13:04:26 PST ---
> So Page::suspend() and Page::resume() are called by the embedder?
Correct

>  Why doesn't
> Page::resume() do anything to already suspended geolocations?
If we go for this route of adding Page::suspend/resume, it should. Currently in
Android, calling Geolocation::suspend/resume is done from WebKit, but it would
be better to do it from Page::suspend/resume. This is already on my list of
things to fix. I've opened Bug 35313 to track this.

> Is Geolocation done entirely in WebCore?
The platform implementations of GeolocationService live in WebCore/platform.

> I'm surprised that the embedder can't
> control this directly from the embedder's side of things. Why is WebCore code
> required at all.  Can't the embedder just drop the geolocation requests on the
> floor when it wants to?
It could. This was my approach in my first patch on this bug, where
GeolocationServiceAndroid used a new PlatformBridge::isWebViewPaused() method
to determine whether the page is suspended. But you suggested, rightly I think,
that it would be neater if WebKit were to 'reach down into WebCore and set some
sort of pause'.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.