[Webkit-unassigned] [Bug 35308] Make setPrinting(false, ...) restore the previous used media type

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 23 11:43:49 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=35308


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #49312|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #1 from Darin Adler <darin at apple.com>  2010-02-23 11:43:49 PST ---
(From update of attachment 49312)
> +    static String prevMediaType = "screen";

Using a global for this is not a great solution. We would like to be able to
print two different web pages at the same time some day, and restore each to
the correct media type.

We don't have to leave the interface to setPrinting alone -- we can add a new
argument or return value. Or even make a larger change to give it a more
sensible interface.

Otherwise this seems OK.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list