[Webkit-unassigned] [Bug 35287] ImageSourceCG::frameIsCompleteAtIndex returns false for all frames until image has completed loading

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35287


Geoffrey Garen <ggaren at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #49304|review?                     |review+
               Flag|                            |




--- Comment #3 from Geoffrey Garen <ggaren at apple.com>  2010-02-23 11:08:54 PST ---
(From update of attachment 49304)
It looks like the two values we're interested in, when testing "frameStatus >=
kCGImageStatusIncomplete", are:
    kCGImageStatusIncomplete = -1,
    kCGImageStatusComplete = 0

I think it would be better just to test them explicitly: "frameStatus ==
kCGImageStatusIncomplete || frameStatus == kCGImageStatusComplete".

This has the benefit of documenting which values we're testing for without
requiring the reader to flip to another file. Also, unless there's some
explicit API contract somewhere, it's probably better not to assume that
statuses >= kCGImageStatusIncomplete will always be "good" statuses.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.