[Webkit-unassigned] [Bug 35272] [Chromium] Implement WebDocument::getElementsByTagName

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35272





--- Comment #5 from James Hawkins <jhawkins at google.com>  2010-02-23 10:52:06 PST ---
(In reply to comment #4)
> (From update of attachment 49248 [details])
> > Index: WebKit/chromium/public/WebDocument.h
> ...
> >      WEBKIT_API WebElement getElementById(const WebString& id) const;
> > +    WEBKIT_API WebNodeList getElementsByTagName(const WebString&);
> 
> hmm, it seems like getElementsByTagName (like getElementById) should be
> a const method since it does not mutate WebDocument.

More importantly, getElementsByTagName belongs in WebNode, not WebDocument. 
The original problem remains though: I can't make WebNode::getElementsByTagName
const because WebCore::Node::getElementsByTagName is non-const.  The Node
method caches the NodeList in the document for future reference.  Patch will
follow.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.