[Webkit-unassigned] [Bug 35233] Optimize Latin-1 decoding in TextCodecLatin1::decode()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35233


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #49275|review?, commit-queue?      |review+, commit-queue+
               Flag|                            |




--- Comment #9 from Darin Adler <darin at apple.com>  2010-02-23 07:39:05 PST ---
(From update of attachment 49275)
> +        * platform/text/TextCodecLatin1.cpp:
> +        (WebCore::):
> +        (WebCore::TextCodecLatin1::decode):

You should delete partial lines like that "WebCore::" one there. They're
created due to a bug in the script.

> +template<> struct NonASCIIMask<8> {
> +    static uintptr_t value() { return 0x8080808080808080UL; }
> +};

I was concerned that compiling this might yield warnings on 32-bit platforms.
That's why I used the type "unsigned long long" in my suggested code. I guess
we're OK because the "UL" suffix makes it an unsigned long, not unsigned long
long. I meant to use "ULL".

Please investigate writing full words as well and applying this same
optimization to the increasingly-often-used UTF-8 decoder as well.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.