[Webkit-unassigned] [Bug 35153] [Qt] WebGL support missing in QtWebKit

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35153


Kenneth Rohde Christiansen <kenneth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #49279|review?                     |review-
               Flag|                            |




--- Comment #15 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2010-02-23 05:46:29 PST ---
(From update of attachment 49279)

> +
> +typedef void (APIENTRY *glActiveTextureType) (GLenum);
> +typedef void (APIENTRY *glAttachShaderType) (GLuint, GLuint);
> +typedef void (APIENTRY *glBindAttribLocationType) (GLuint, GLuint, const char *);
> +typedef void (APIENTRY *glBindBufferType) (GLenum, GLuint);

Lost of these have wrong coding style, like the * should be left aligned, thus:

+typedef void (APIENTRY* glBindAttribLocationType) (GLuint, GLuint, const
char*)

We are pretty strict about coding style in WebKit, thus r-. Please make use of
the tool check-webkit-style which can be found in WebKitTools/Scripts

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.