[Webkit-unassigned] [Bug 35274] DRT Annoyance(r55107): Inspector window appears and disappears when running the layout tests on mac

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35274





--- Comment #8 from Brady Eidson <beidson at apple.com>  2010-02-23 00:52:01 PST ---

> Can we make sure that defaults (DRT's 800x600 and default inspector ratio)
> allow docking? That would make DRT happy. If not, we should extend DRT and
> disable this behavior explicitly.

Thinking it was very odd that docking wouldn't work with 800px height, I tried
this locally.  It's completely busted.  I didn't notice the glaring bug because
I happened to be testing with either "really tiny" window heights and 1000+px
window heights. I know exactly what I need to do to fix it, and that will again
hide the window in DRT.

That said, I have no tree to work out of right now and won't till tomorrow. 
I'll pre-emptively rubberstamp someone rolling it out if they truly can't stand
it until tomorrow, or I'll get to fixing it tomorrow morning.

That said...

(In reply to comment #7)
> This is really annoying and should be fixed asap. Our tests are already taking
> too long, so we can't afford the luxury of opening inspector window.

I agree the bug is annoying - but it does *NOT* make the inspector tests take
longer.  Each test took about 1 second before my change, and each test takes
about 1 second after my change.

Opening the web inspector is a painfully, unacceptably slow operation in
general.  Doing so in DRT is no exception, even when the window is hidden.

> 2) Furthermore, I see no changes to the frontend and that makes me think that
> "dock" button will anyways be visible and enabled. What happens when user
> clicks it?

You're right, there were no front-end changes in this patch.  I thought I filed
a followup, but now that I can't find it by searching from home, I'm sure my
browser @ work is sitting on the submit screen reminding me I forgot to choose
a component.  ;)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.