[Webkit-unassigned] [Bug 34683] [Haiku] Implement Path, Gradient and flesh out GraphicsContextHaiku

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34683





--- Comment #9 from Eric Seidel <eric at webkit.org>  2010-02-22 13:24:58 PST ---
(From update of attachment 48991)
I sometimes wrap locking blocks in { } to indicate that I'm holding a lock, I'm
not sure what WebKit's official style is.  We generally use stack objects to do
locking/unlocking automatically for us:
84     bitmap.Lock();
 85     bitmap.AddChild(&view);
 86     // Current pen location is used as origin for the shape.
 87     view.MovePenTo(-point.x(), -point.y());
 88     // TODO: Handle WindRule... (needs support in BView, the backend
already
 89     // support it.)
 90     view.FillShape(m_path);
 91     view.Sync();
 92 
 93     uint8* bits = reinterpret_cast<uint8*>(bitmap.Bits());
 94     bool result = bits[0] < 128;
 95 
 96     view.RemoveSelf();
 97     bitmap.Unlock();

Yeah, given that you do it twice, i tmight make sense to write a simple
auto-locking class for just use within this file.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.