[Webkit-unassigned] [Bug 35184] Add another test case to the iframes-shims test

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 22 13:18:38 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=35184





--- Comment #6 from Thatcher Ulrich <tulrich at google.com>  2010-02-22 13:18:38 PST ---
(In reply to comment #5)
> (From update of attachment 49237 [details])
> It seems wrong that it is necessary to call setFrameRect() even when the frame
> has not changed. setFrameRect() should not have side effects. Whatever needs
> doing for windows plugins should be separated out into a method that is called
> at the appropriate times.

frameRectsChanged() is an existing call and would work here.  But I'm not sure
if that conflicts with the intended semantics of frameRectsChanged().  I can
invent a new virtual function in Widget if you think that makes more sense.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list