[Webkit-unassigned] [Bug 35210] [Gtk] implements ChromeClient::requestGeolocationPermissionForFrame

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35210


Gustavo Noronha (kov) <gns at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #49148|review?                     |review-
               Flag|                            |




--- Comment #3 from Gustavo Noronha (kov) <gns at gnome.org>  2010-02-22 09:44:08 PST ---
(From update of attachment 49148)
Thanks for the patch! I think the idea of a signal is a good one, but I think
the frame_allow_geolocation function is not a very good interface. I think the
signal should probably return a boolean to set if it is handled or not, and we
could use a policy object, similar to the WebPolicyDecision. So, say,
GeolocationPolicyDecision. You would emit the signal, and you would have a
default implementation that denies the policy decision. I think that will allow
us flexibility to further improve the API as the web standards move forward.
I'll CC xan here, too, so he can comment. You also need to address the style
issues.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.