[Webkit-unassigned] [Bug 34940] [Gtk] testwebview does not work when called with absolute path

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 22 09:17:18 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=34940


Gustavo Noronha (kov) <gns at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #49091|review?                     |review-, commit-queue-
               Flag|                            |




--- Comment #5 from Gustavo Noronha (kov) <gns at gnome.org>  2010-02-22 09:17:18 PST ---
(From update of attachment 49091)
 30 extern int testutils_relative_chdir(const gchar*, const gchar*);

Adding a header, and a proper signature would be better, plus, you should add
the bug URL, and its description to the changelog:

 8         Need a short description and bug URL (OOPS!)

Otherwise, this patch is a good step forward, thanks for taking the time to
refactor this! One more round to fix up these two small issues, and I'll r+ it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list