[Webkit-unassigned] [Bug 34366] [OpenVG] Implement support for paths

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34366





--- Comment #6 from Dirk Schulze <krit at webkit.org>  2010-02-22 09:10:10 PST ---
(From update of attachment 48904)
> +PlatformPathOpenVG::PlatformPathOpenVG(const PlatformPathOpenVG& other)
> +    : SharedResourceOpenVG()
> +    , m_currentPoint(other.m_currentPoint)
> +    , m_subpathStartPoint(other.m_subpathStartPoint)
> +{
> +    createPath();
> +    // makeCompatibleContextCurrent(); // called by createPath(), not necessary
> +    vgAppendPath(m_vgPath, other.m_vgPath);
> +    ASSERT_VG_NO_ERROR();
> +}
There shouldn't be two comments in one line.

> +
> +PlatformPathOpenVG& PlatformPathOpenVG::operator=(const PlatformPathOpenVG& other)
> +{
> +    if (&other != this) {
> +        clear();
> +        // makeCompatibleContextCurrent(); // called by clear(), not necessary
> +        vgAppendPath(m_vgPath, other.m_vgPath);
> +        ASSERT_VG_NO_ERROR();
> +    }
> +    return *this;
> +}
The same here.

> +bool Path::contains(const FloatPoint& point, WindRule rule) const
> +{
> +    notImplemented();
> +
> +    // OpenVG has no path-contains function, so for now we approximate by
> +    // using the bounding rect of the path.
> +    return boundingRect().contains(point);
> +}
If I undersand Ariya correctly, ha wants you to either choose noImplemented()
or the comment with the immedate code.

Personaly, I would like to see the OpenVG port fixed, so that you can use
AffineTransform here. I'm blameable for this breakage with the AffineTransform
implementation, so I would like to help on fixing the issues.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.