[Webkit-unassigned] [Bug 35233] Optimize Latin-1 decoding in TextCodecLatin1::decode()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35233


Sam Weinig <sam at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #49197|review?                     |review-
               Flag|                            |




--- Comment #2 from Sam Weinig <sam at webkit.org>  2010-02-22 07:12:14 PST ---
(From update of attachment 49197)
> +#if CPU(X86_64) || CPU(SPARC64) || CPU(IA64) || CPU(PPC64)
> +#define NON_ASCII_MASK 0x8080808080808080
> +typedef uint64_t CpuWord;
> +#else
> +#define NON_ASCII_MASK 0x80808080
> +typedef uint32_t CpuWord;
> +#endif

Nice optimization. Two nits.
NON_ASCII_MASK should be a constant instead of a #define.
Can you use intptr_t instead of CpuWord?

r- to address these.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.