[Webkit-unassigned] [Bug 33995] Web Inspector: Additional instrumentation for Timeline

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33995





--- Comment #24 from Pavel Feldman <pfeldman at chromium.org>  2010-02-22 03:36:31 PST ---
Few more comments on the UI:
1. "Name: Timer fired" should be rendered as a popover title "Timer fired"
(https://bug-35003-attachments.webkit.org/attachment.cgi?id=49008).
2. There is no need in the Even Type since event's name gives much better clue
on the event origin.
3. You should have sections for generic attributes (start time, duration,
caller) and event specifics (timeout, timer id). Specifics should probably go
first.
4. "Installed at" seems to be too sophisticated to me. I would appreciate a
hyperlink to a Install Timer record in a form of timer id instead. Install
timer record would have Caller link. Yes, it is two clicks, but we are not
talking about a general operation here, while limiting term vocabulary to
"Caller" makes it more clear to user.
5. I'd render start time and duration on single line
6. Timer Fired is likely to have nesting 'Function Call' record. That is true
for all the native events that call into JavaScript. However, unlike DOM
events, timer fired is only going to make single function call. It would be
great if we could should Function Call information in-place in this Timer Fired
popover. I.e. which function and where is being called by this event. We can
also merge Event and Function Call records entirely in all places where Event
leads to exactly single Function Call.

I think 1-5 are worth fixing right away, while (6) can wait. Thoughts?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.