[Webkit-unassigned] [Bug 33995] Web Inspector: Additional instrumentation for Timeline

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33995


Timothy Hatcher <timothy at hatcher.name> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #49168|review?                     |review-
               Flag|                            |




--- Comment #22 from Timothy Hatcher <timothy at hatcher.name>  2010-02-22 03:01:28 PST ---
(From update of attachment 49168)
I'm not awake enough for a detailed line by line review but here are soome
highlevel comments and questions:

Why is there a thicker padding at the bottom of the popover in the screenshot?

The labels should be consistent and Title Case. But I think "Single shot"
should be renamed to be "Repeats" and flip the boolean. And "installed at"
should be "Call Site" or something not ending in "at".

hideAtClick should be named "hideWhenClicked" and would be more logical as a
setter, but a function is fine if only just renamed.

You have some style problems in at least TimelinePanel.js:

 640             }
 641             else if ( this._record.type ==
WebInspector.TimelineAgent.RecordType.FunctionCall ) {
 642                 var link =
WebInspector.linkifyResourceAsNode(this._record.data.scriptName, "scripts",
this._record.data.scriptLine);
 643                
bubbleContentTable.appendChild(this._createLinkRow(WebInspector.UIString("Location"),
link));
 644             }
 645             else
 646                
bubbleContentTable.appendChild(this._createRow(WebInspector.UIString("Details"),

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.