[Webkit-unassigned] [Bug 35228] [Gtk] Implement layoutTestController.numberOfPages

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 22 00:08:01 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=35228





--- Comment #3 from Shinichiro Hamaji <hamaji at chromium.org>  2010-02-22 00:08:01 PST ---
> Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
> WebKitTools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:59: 
> webkit_web_frame_number_of_pages is incorrectly named. Don't use underscores in
> your identifier names.  [readability/naming] [4]
> WebKit/gtk/webkit/webkitwebframe.cpp:879:  Use 0 instead of NULL. 
> [readability/null] [5]
> Total errors found: 2 in 7 files
> 
> 
> If any of these errors are false positives, please file a bug against
> check-webkit-style.

Ah, I forgot to fix this false alarms. Filed Bug 35229 and submitted a patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list