[Webkit-unassigned] [Bug 35226] Cache JavaScript wrappers inline in DOM nodes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35226


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #49181|review?                     |review+
               Flag|                            |




--- Comment #2 from Darin Adler <darin at apple.com>  2010-02-21 20:34:53 PST ---
(From update of attachment 49181)
>  void forgetDOMObject(DOMObject* wrapper, void* objectHandle)
>  {
> +    
>      JSC::JSGlobalData* globalData = Heap::heap(wrapper)->globalData();

No need for this added blank line.

> -    JSNode* getCachedDOMNodeWrapper(JSC::ExecState*, Document*, Node*);
> +    JSNode* getCachedDOMNodeWrapper(JSC::ExecState*, Node*);

This is defined in JSNodeCustom.h instead of this header. Why?

> +    inline DOMObjectWrapperMap& DOMObjectWrapperMapFor(JSC::ExecState* exec)
> +    {
> +        return currentWorld(exec)->m_wrappers;
> +    }

In the past we have lowercased even acronyms like DOM here at the start of a
function name. Maybe there's some way to dodge the issue.

r=me

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.