[Webkit-unassigned] [Bug 35205] [Chromium API] Disambiguate allowJavaScript from didFailToExecuteJavaScript

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Feb 20 22:48:10 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=35205


Peter Kasting <pkasting at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[Chromium API] Disambiguous |[Chromium API] Disambiguate
                   |allowJavaScript from        |allowJavaScript from
                   |didFailToExecuteJavaScript  |didFailToExecuteJavaScript




--- Comment #2 from Peter Kasting <pkasting at google.com>  2010-02-20 22:48:10 PST ---
You might want to comment more (perhaps in comments on the function
declarations?) on why a piece of code would care whether it can execute script
if it doesn't actually intend to execute script.  There are other possible APIs
here whose usefulness probably depends on the answer.

(I'm mostly worried about future code calling allowJavaScript() without calling
didFailToExecuteJavaScript() when it should.  Perhaps we should create a single
access point you call when you want to run script that checks if it's legal and
calls this callback if not, or something.)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list