[Webkit-unassigned] [Bug 34782] Normalize custom ctors for Image, Option, Audio

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Feb 20 09:31:58 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=34782





--- Comment #20 from Darin Adler <darin at apple.com>  2010-02-20 09:31:57 PST ---
(In reply to comment #17)
> BTW, audio.autobuffer is true by default, but I tested anyway.

I suggest removing the unneeded line of code setting autobuffer, then.

    audio->setAutobuffer(true);

If it's true by default that line should not be needed.

> p.s. Whitespace changes: AFAIK, the latest webkit style rule about whitespace
> changes is that if I made real edits elsewhere in these files, its ok. I'm
> using an automated tool to fix whitespace changes, and the new changes are
> correct.

I think this rule is strange, and I don't agree with it; I'm not sure how it
became the "latest rule". I don't think it's good to have automated tools
making insignificant changes that harm our ability to find real changes in file
history and provide no tangible benefit.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list