[Webkit-unassigned] [Bug 34915] Chromium: Need to be able to get the bounds of selection rectangle(s)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 19 16:10:17 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=34915





--- Comment #10 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2010-02-19 16:10:17 PST ---
(From update of attachment 49107)
> +++ b/WebKit/chromium/src/WebFrameImpl.cpp
> @@ -1534,6 +1534,16 @@ int WebFrameImpl::pageNumberForElementById(const WebString& id,
>      return PrintContext::pageNumberForElement(element, pageSize);
>  }
>  
> +WebRect WebFrameImpl::selectionBoundsRect() const
> +{
> +    if (hasSelection()) {
> +        FloatRect fr = frame()->selectionBounds(false);
> +        return WebRect(fr.x(), fr.y(), fr.width(), fr.height());

if (hasSelection())
    return WebRect(frame()->selectionBounds(false));

^^^ that should also compile, right?  the FloatRect gets implicitly converted
to IntRect, which matches a WebRect constructor.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list