[Webkit-unassigned] [Bug 34219] [Gtk] Server message not shown on http authentication

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34219


José Millán Soto <jmillan at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #47947|0                           |1
        is obsolete|                            |
  Attachment #49098|                            |review?
               Flag|                            |




--- Comment #13 from José Millán Soto <jmillan at igalia.com>  2010-02-19 11:29:34 PST ---
Created an attachment (id=49098)
 --> (https://bugs.webkit.org/attachment.cgi?id=49098)
Patch to make server message visible in http authentication dialog

This one creates only three rows if there's a realm.

(In reply to comment #12)
> - You are checking that the string is not NULL, but I guess you should also
> check that it's not ""?
Actually, I was checking that if it was "" (by checking realm[0]) and I was not
checking if it was NULL.

Now, I use strlen instead of doing realm[0] to check if it's an empty string
and it's also checked if it's NULL (soup_auth_get_realm should not return NULL,
but just in case)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.