[Webkit-unassigned] [Bug 35084] New port: EFL; adding files to JavaScriptCore/wtf/efl

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35084


Gustavo Noronha (kov) <gns at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gns at gnome.org




--- Comment #8 from Gustavo Noronha (kov) <gns at gnome.org>  2010-02-19 09:57:53 PST ---
(In reply to comment #7)
> (In reply to comment #6)
> > (From update of attachment 49069 [details] [details])
> > So what do you use the EOwnPtr for ? basically it is a define for the GOwnPtr
> > that works together with the GObject I suppose.
> > 
> 
> Currently the soup network backend includes GOwnPtr, which is only defined in
> JSC/wtf/gtk. Since GOwnPtr is used elsewhere throughout the GTK+ port and it
> doesn't actually rely on GTK+, I don't know what to do.
> 
> The EFL port currently copies files from other ports. Its been like this since
> it was first developed, and we're rewriting/using common implementations as
> much as time permits. It is on our todo list to improve this gradually, though.

As we discussed briefly in #webkit-gtk, we go out of our way to make sure JSC
does not depend on GTK+, so GOwnPtr is only related to gobject, not GTK+. I
believe it is fine to rename JavaScriptCore/wtf/gtk to
JavaScriptCore/wtf/gobject, to make it clearer that it is not specific to the
GTK+ port, but to any gobjects-using port.

I'm not sure whether you will use our Threading, and MainThread
implementations, though, but feel free to move GOwnPtr, and GRefPtr to a
gobject directory (as long as you fix the paths in our build system, it won't
be a problem for us at all).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.