[Webkit-unassigned] [Bug 35084] New port: EFL; adding files to JavaScriptCore/wtf/efl

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35084


Oliver Hunt <oliver at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #48993|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #3 from Oliver Hunt <oliver at apple.com>  2010-02-18 22:28:01 PST ---
(From update of attachment 48993)
Welcome to WebKit :D

This patch is basically fine, but you shouldn't add
JavaScriptCore/wtf/efl/EOwnPtr.cpp as it's an (effectively) empty file.

You also need a changelog, to create it use the prepare-ChangeLog script, and
add appropriate description.

I'll r- this patch and wait for an updated patch with a changelog and the
superfluous file removed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.