[Webkit-unassigned] [Bug 34782] Normalize custom ctors for Image, Option, Audio

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34782





--- Comment #15 from Darin Adler <darin at apple.com>  2010-02-18 13:34:28 PST ---
(In reply to comment #13)
> +    // Calling toJS on the document causes the JS document wrapper to be
> +    // added to the window object. This is done to ensure that
> JSDocument::markChildren
> +    // will be called, which will cause the audio element to be marked if
> necessary.
> +    // FIXME: The correct way to do this would be to make HTMLMediaElement
> derive from
> +    // ActiveDOMObject and use its interface to keep its wrapper alive. Then
> we would
> +    // remove this code and the special case in isObservableThroughDOM.
> 
> Active DOM objects are marked from JSDocument::markChildren, so it seems that
> we would still need a document wrapper.

Good point. It seems the FIXME that I wrote that Yaar merged into his patch is
wrong. Lets just leave the FIXME part of the comment out.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.