[Webkit-unassigned] [Bug 34940] [Gtk] testwebview does not work when called with absolute path

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34940


Gustavo Noronha (kov) <gns at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #48749|review?                     |review-, commit-queue-
               Flag|                            |




--- Comment #2 from Gustavo Noronha (kov) <gns at gnome.org>  2010-02-18 06:06:40 PST ---
(From update of attachment 48749)
That looks good. I'm afraid at least one more test needs this fix, though, and
it would be good to have this split to a function in an utils file. Would you
mind applying the fix to the other file, and potentially do this refactoring?
It's OK if you just apply the fix to the other files, but the refactoring would
rock =).

 236     if (g_path_is_absolute (argv[0])) {
 237         g_chdir (g_path_get_dirname (argv[0]));

These spaces before the ( are wrong, r- for this style problem.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.