[Webkit-unassigned] [Bug 35087] New port: EFL; adding files to WebCore/*/efl
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Feb 18 04:07:09 PST 2010
https://bugs.webkit.org/show_bug.cgi?id=35087
--- Comment #10 from WebKit Review Bot <webkit.review.bot at gmail.com> 2010-02-18 04:07:09 PST ---
Attachment 48996 did not pass style-queue:
Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/platform/graphics/efl/IntPointEfl.cpp:34: Evas_Point is incorrectly
named. Don't use underscores in your identifier names. [readability/naming]
[4]
WebCore/platform/graphics/efl/FloatRectEfl.cpp:34: Eina_Rectangle is
incorrectly named. Don't use underscores in your identifier names.
[readability/naming] [4]
WebCore/platform/graphics/efl/FontCustomPlatformData.h:29: cairo_font_face_t
is incorrectly named. Don't use underscores in your identifier names.
[readability/naming] [4]
WebCore/platform/graphics/efl/MediaPlayerPrivateGStreamer.cpp:35: Alphabetical
sorting problem. [build/include_order] [4]
WebCore/platform/graphics/efl/VideoSinkGStreamer.h:65: parent_class is
incorrectly named. Don't use underscores in your identifier names.
[readability/naming] [4]
WebCore/platform/graphics/efl/VideoSinkGStreamer.h:76:
webkit_video_sink_get_type is incorrectly named. Don't use underscores in your
identifier names. [readability/naming] [4]
WebCore/platform/graphics/efl/VideoSinkGStreamer.h:79:
webkit_video_sink_set_surface is incorrectly named. Don't use underscores in
your identifier names. [readability/naming] [4]
WebCore/platform/graphics/efl/IntRectEfl.cpp:34: Eina_Rectangle is incorrectly
named. Don't use underscores in your identifier names. [readability/naming]
[4]
Total errors found: 8 in 17 files
If any of these errors are false positives, please file a bug against
check-webkit-style.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list