[Webkit-unassigned] [Bug 34879] pywebsocket should support html and cgi in the same directory.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34879





--- Comment #9 from Fumitoshi Ukai <ukai at chromium.org>  2010-02-18 03:02:36 PST ---
(In reply to comment #8)
> (From update of attachment 48963 [details])
> Underscores are a strange Google convention.  WebKit-land uses dashes. 

I think pywebsocket is third party code, so don't need to flow WebKit-style.

> Also,
> you patch does not appear to apply cleanly to top of tree.

Hmm, this is webkit-patch (with git) bug, when moving files and directory
becomes empty?

webkit-patch apply-attachment says
$ ./WebKitTools/Scripts/webkit-patch apply-attachment 48963
Cleaning working directory
Updating working directory
Reading Keychain for bugs.webkit.org account and password.  Click "Allow" to
continue...
Logging in as ukai at chromium.org...
Fetching: https://bugs.webkit.org/attachment.cgi?id=48963&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=34879&ctype=xml
Processing 1 patch from 1 bug.
Processing patch 48963 from bug 34879.
Failed to run
"['/Users/ukai/src/chromium-webkit2/src/third_party/WebKit/WebKitTools/Scripts/svn-apply']"
exit_code: 2
Last 500 characters of output:
h fuzz 3.
patching file WebKitTools/Scripts/run-webkit-tests
patching file WebKitTools/Scripts/run-webkit-websocketserver
patching file
WebKitTools/Scripts/webkitpy/layout_tests/port/websocket_server.py
patching file WebKitTools/pywebsocket/mod_pywebsocket/standalone.py
patching file WebKitTools/pywebsocket/setup.py
Could not open 'LayoutTests/websocket/tests/cookies' to list files: 0 at
/Users/ukai/src/chromium-webkit2/src/third_party/WebKit/WebKitTools/Scripts/svn-apply
line 314, <> line 417.

Failed to run
"['/Users/ukai/src/chromium-webkit2/src/third_party/WebKit/WebKitTools/Scripts/svn-apply']"
exit_code: 2
ukai-macpro:WebKit ukai$ git reset --hard

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.