[Webkit-unassigned] [Bug 33995] Web Inspector: Additional instrumentation for Timeline

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33995


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #48902|review?                     |review-
               Flag|                            |




--- Comment #18 from Pavel Feldman <pfeldman at chromium.org>  2010-02-18 02:22:17 PST ---
(From update of attachment 48902)
> +        static bool getCallerScriptInfo(String& sourceName, int& sourceLineNumber);
> +

callScriptInfo (or even better callLocation)
return parameters should be passed by pointer.

>  {
>      ScriptObject record = TimelineRecordFactory::createGenericRecord(m_frontend, currentTimeInMilliseconds());
>      record.set("data", TimelineRecordFactory::createGenericTimerData(m_frontend, timerId));
> +    populateCallerInfo(record);
>      addRecordToTimeline(record, TimerRemoveTimelineRecordType);
>  }

We can inline populateCallerInfo into the createGenericRecord.

>  } // namespace WebCore

Warning, strange indent above this line.

>  
>          // Make resource receive record last since request was sent; make finish record last since response received.
>          if (record.type === WebInspector.TimelineAgent.RecordType.ResourceSendRequest) {
> @@ -210,12 +217,32 @@ WebInspector.TimelinePanel.prototype = {
>              if (sendRequestRecord) { // False if we started instrumentation in the middle of request.
>                  sendRequestRecord._responseReceivedFormattedTime = formattedRecord.startTime;
>                  formattedRecord.startTime = sendRequestRecord.startTime;
> -                sendRequestRecord.details = this._getRecordDetails(record);
> +                formattedRecord.details = this._getRecordDetails(sendRequestRecord);
> +                formattedRecord.callerScriptName = sendRequestRecord.callerScriptName;
> +                formattedRecord.callerScriptLine = sendRequestRecord.callerScriptLine;

No need to set javascript caller to the event that is dispatched from other
places (timer, network, etc.).


> +                   record.type === WebInspector.TimelineAgent.RecordType.TimerRemove) {
> +            var timerInstalledRecord = this._timerRecords[record.data.timerId];
> +            if (timerInstalledRecord) {
> +                if (!formattedRecord.callerScriptName) {

Timer remove has its own caller info.
> +        if (document._bubble) {
> +            document._bubble.hide();
> +        }

Non need for { }

Let us look at bubble together and we will merge it with Popover.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.