[Webkit-unassigned] [Bug 35022] [V8] Refactor ScheduledAction to support different kinds of actions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35022





--- Comment #4 from Dominic Cooney <dominicc at google.com>  2010-02-18 01:28:16 PST ---
(In reply to comment #2)
> How does this look performance-wise? Any visible regressions? I am ok with the
> change if it doesn't introduce perf regressions.

I wrote a microbenchmark, first just calling execute (with no context =>
execute doesn't find a V8 context and exits); then creating and destroying the
(V8)ScheduledAction as well. The difference looks to be within noise, <0.5%. I
ran the Chromium perf test suite.

(In reply to comment #3)
> Why is this useful?

V8 has two scheduled actions--one with a window context; one with a worker
context. I'm separating the interface so that we can have different kinds of
scheduled actions in Chromium without having to wind them together in the same
file with if statements.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.