[Webkit-unassigned] [Bug 34879] pywebsocket should support html and cgi in the same directory.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34879





--- Comment #4 from Fumitoshi Ukai <ukai at chromium.org>  2010-02-17 19:21:06 PST ---
(In reply to comment #3)
> +        specify --server_host 127.0.0.1 -x /websocket/tests
> 
> What is --server-host, and why is it good to specify it? I think I know the
> answer, but please explain it in ChangeLog.

Ok.

> Seems untidy to have a mix of short and long option names.

Changed to use long option names.

> >             if '..' in self.path:
> >                 return False
> 
> Do functions that we use for path manipulation perform tilde expansion (for
> home directory)? Writing a truly secure server is out of scope for the test
> tool, it's just too similar to existing check for "..", so I wanted to ask.

I believe it doesn't perform tilde expansion.

> +            scriptfile = self.translate_path(self.path.split('?', 2)[0])
> 
> I don't understand what this line does. Someone who is better familiar with
> Python might understand it, and give their r+.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.