[Webkit-unassigned] [Bug 35055] SingleTestThread and TestShellThread should share more code

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35055





--- Comment #4 from Dirk Pranke <dpranke at chromium.org>  2010-02-17 17:10:10 PST ---
please reformat this to stay within 80 columns as per the PEP 8 style guide :)

I think this patch is safe, but is basically rearranging ugly code. You put a
FIXME in somewhere to just collapse the two classes, and I agree that that
would probably be a better way to fix this. Is there some reason you're not
doing that as part of this patch?

Also, I believe this --run-singly option is only used by the valgrind bots
(presumably to help ensure clean test runs); you might put a comment into the
code somewhere to indicate this, so people can understand why we need this
option at all.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.