[Webkit-unassigned] [Bug 33570] [BREWMP] Map FastMalloc to BREW memory allocator

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 17 15:17:53 PST 2010


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
  Attachment #48198|review?, commit-queue?      |review-
               Flag|                            |

--- Comment #12 from Eric Seidel <eric at webkit.org>  2010-02-17 15:17:52 PST ---
(From update of attachment 48198)
Please add a comment before the #defines explaining why they're the right thing
to do. Similar perhaps to how you explained things in teh bug.  That although
BREW defines "malloc()" you can't use it because the loader does not initialize
the base address properly.  (Is this a bug in brew?  If so, is there a bug url
tracking it?  If so, you should include it.)

Once we have enough justification in the code, we can land this kind of hack. 
As is I think this code would just confuse future folks trying to read it.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list