[Webkit-unassigned] [Bug 34975] [Qt] Correct build problems while building QtWebKit inside Qt.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34975


Laszlo Gombos <laszlo.1.gombos at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #48869|review?                     |review+
               Flag|                            |




--- Comment #4 from Laszlo Gombos <laszlo.1.gombos at nokia.com>  2010-02-17 14:38:32 PST ---
(From update of attachment 48869)
Looks good to me, r+.

It would be better to assign value to VERSION at same location. Perhaps you can
make that change during landing just by moving some code around.

Something like this:

CONFIG(QTDIR_build) {
    include($$QT_SOURCE_TREE/src/qbase.pri)
    # Qt will set the version for us when building in Qt's tree
    VERSION=$${QT_MAJOR_VERSION}.$${QT_MINOR_VERSION}.$${QT_PATCH_VERSION}
} else: VERSION = 4.7.0

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.