[Webkit-unassigned] [Bug 35055] SingleTestThread and TestShellThread should share more code

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 17 13:53:52 PST 2010


--- Comment #3 from Ojan Vafai <ojan at chromium.org>  2010-02-17 13:53:52 PST ---
(From update of attachment 48933)
> +# FIXME: Why do we need a separate class to handle --singly?  Can't we just use many
> +# TestShellThreads and only feed each one test?
> +class SingleTestThread(TestThread):

Actually, now that I look more closely at this, I'm not even sure we need that.
What's weird right now is that SingleTestThread is spawned from
TestShellThread. It's not clear to me why _run_test_singly doesn't just kill
testshell/drt and then start it up again.

Anyways, it's a FIXME. Otherwise, LGTM.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list