[Webkit-unassigned] [Bug 33180] [Qt] Support private browsing mode in plugins

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33180





--- Comment #10 from Robert Hogan <robert at roberthogan.net>  2010-02-17 11:35:09 PST ---
(In reply to comment #8)
> (From update of attachment 47448 [details])
> 
> > +    case NPNVprivateModeBool: {
> > +        Page* page = m_parentFrame->page();
> > +        if (!page)
> > +            return NPERR_GENERIC_ERROR;
> > +        *((NPBool*)value) = !page->settings() || page->settings()->privateBrowsingEnabled();
> > +        return NPERR_NO_ERROR;
> > +    }
> 
> r=me, but when landing you may want to change the above to return
> NPERR_GENERIC_ERROR if !page->settings() and only return the real value to the
> plugin if we have a settings object.

Elsewhere in the code the default behaviour for security-sensitive settings is
to assume that if !page->settings() then the setting is true.

e.g. in WebCore/loader/DocLoader.cpp:

    Settings* settings = frame()->settings();
    if (!settings || settings->privateBrowsingEnabled())
        return;

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.