[Webkit-unassigned] [Bug 34962] Geolocation object requires a means to cancel a permission request

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34962


Steve Block <steveblock at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joth at chromium.org




--- Comment #3 from Steve Block <steveblock at google.com>  2010-02-17 03:30:02 PST ---
(In reply to comment #2)
> You're not hooking this up in WebKit, and doing the work only in WebCore.
>
> That seems strange; maybe OK for Chromium, but not right for other platforms
> except the ones that aren't doing Geolocation at all.
This patch was motivated by the needs of Android. WebKit/android isn't yet
upstreamed, which is why there's no WebKit implementation.

> I think we should use the traditional "Geolocation" rather than "Geolococation"
Will fix

> Making this an empty function rather than pure virtual makes it easier to keep
> all the platforms compiling, but hides the work needed for platforms that
> currently have requestGeolocationPermissionForFrame functions defined. Why did
> we make the function above this pure virtual but not this one?
All platforms supporting Geolocation will need to implement
requestGeolocationPermissionForFrame. However, I can imagine a situation where
a platform may not need to know when an individual Geolocation object is
canceling a request - for example, if permissions UI is only cleared when the
page is navigated away. That's why cancelGeolocationPermissionRequestForFrame
was empty.

However, I've just spoken to joth (cc'ed) who's doing Chromium Geolocation and
they're likely to use such a callback too. So I'll change to a pure virtual
method in ChromeClient. Note that even for Chromium the implementation will
currently be empty as Chromium Geolocation is not yet complete.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.