[Webkit-unassigned] [Bug 34969] [chromium] expose endToEnd flag in reload() API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34969





--- Comment #5 from Evan Martin <evan at chromium.org>  2010-02-17 02:11:27 PST ---
Here's the code in FrameLoader:

    if (loadType == FrameLoadTypeReload) {
        request.setCachePolicy(ReloadIgnoringCacheData);
        request.setHTTPHeaderField("Cache-Control", "max-age=0");
    } else if (loadType == FrameLoadTypeReloadFromOrigin) {
        request.setCachePolicy(ReloadIgnoringCacheData);
        request.setHTTPHeaderField("Cache-Control", "no-cache");
        request.setHTTPHeaderField("Pragma", "no-cache");

endToEnd=true causes the second loadtype:
    loadWithDocumentLoader(loader.get(), endToEndReload ?
FrameLoadTypeReloadFromOrigin : FrameLoadTypeReload, 0);

You worried about the effects of using ReloadIgnoringCacheData in the the
review: "I'm afraid that if it is also setting ReloadIgnoringCacheData
that our disk cache will be evicted even for an otherwise conditional
request" but I don't know enough about this code to know what the effects of it
are.


Here's the text of the RFC:

   End-to-end reload
      The request includes a "no-cache" cache-control directive or, for
      compatibility with HTTP/1.0 clients, "Pragma: no-cache". Field
      names MUST NOT be included with the no-cache directive in a
      request. The server MUST NOT use a cached copy when responding to
      such a request.

   Specific end-to-end revalidation
      The request includes a "max-age=0" cache-control directive, which
      forces each cache along the path to the origin server to
      revalidate its own entry, if any, with the next cache or server.
      The initial request includes a cache-validating conditional with
      the client's current validator.

Because "end to end reload" is the wording used in the RFC, I can see where the
WebKit name came from.  But I agree that it is very confusing.

>From your other mails I saw these suggestions:
  LOAD_VALIDATE_CACHE / LOAD_BYPASS_CACHE
  RELOAD_VALIDATING_CACHE / RELOAD_IGNORING_CACHE

I will arbitrarily go with ignoreCache and upload another patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.