[Webkit-unassigned] [Bug 34382] When a live iframe element is moved between pages, it still depends on the old page.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34382


David Levin <levin at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #48684|review?                     |review+
               Flag|                            |




--- Comment #34 from David Levin <levin at chromium.org>  2010-02-17 01:01:26 PST ---
(From update of attachment 48684)
r=me (as long as there are ok's from the other two folks involved for qt and
chromium specific changes).

Two minor nits below.


> diff --git a/WebCore/html/HTMLFrameOwnerElement.h b/WebCore/html/HTMLFrameOwnerElement.h
> +    virtual void setName() {}

Would be nice to add a space inside of the {}.


> diff --git a/WebCore/loader/EmptyClients.h b/WebCore/loader/EmptyClients.h
> +    virtual void didTransferChildFrameToNewDocument() { return; }

"return;" isn't needed here.  In other words, s/{ return; }/{ }/

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.