[Webkit-unassigned] [Bug 35000] [Chromium] Remove calls to releaseRef when passing PassRefPtrs to base classes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35000


Darin Fisher (:fishd, Google) <fishd at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #48837|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #2 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2010-02-16 14:59:33 PST ---
(From update of attachment 48837)
> Index: WebKit/chromium/ChangeLog
...
> +        Reviewed by NOBODY (OOPS!).
> +
> +        [Chromium] Remove calls to releaseRef when passing PassRefPtrs to base
> +        classes.  releaseRef releases the original pointer without decreasing
> +        the reference count, and the base class constructor increases the
> +        reference count, leading to a leak.
> +
> +        * src/WebDocument.cpp:

Oops, this ChangeLog needs a bug link.  Otherwise, LGTM

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.