[Webkit-unassigned] [Bug 34922] Mingw-w64 fixes for WebCore and JavaScriptCore

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34922


Gabor Loki <loki at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |loki at webkit.org




--- Comment #13 from Gabor Loki <loki at webkit.org>  2010-02-16 05:23:53 PST ---
>-#if COMPILER(MINGW)
>+#if ( COMPILER(MINGW) && !COMPILER(MINGW64) )

Although the style bot did not say anything about this change, I think this
looks bad.
I have never seen such an #if construct. First of all, leave no space between
parentheses and its content! Additionally, in this case there is no reason to
put
parentheses around this expression.

> /* COMPILER(MINGW) - MinGW GCC */
>-#if defined(MINGW) || defined(__MINGW32__)
>+/* COMPILER(MINGW64) - mingw-w64 GCC - only used as additional check to exclude mingw.org specific functions */
>+#if defined (__MINGW32__)
> #define WTF_COMPILER_MINGW 1
>-#endif
>+#include <_mingw.h> /* private MinGW header */
>+# if defined (__MINGW64_VERSION_MAJOR) /* best way to check for mingw-w64 vs mingw.org */
>+# define WTF_COMPILER_MINGW64 1
>+# endif /* __MINGW64_VERSION_MAJOR */
>+#endif /* __MINGW32__ */

Hmmm, __MINGW32__ is set for MINGW64 as well.
So, you do not need the following extra check on x86:

> #if PLATFORM(QT)
> #if (CPU(X86) && OS(WINDOWS) && COMPILER(MINGW) && GCC_VERSION >= 40100) \
>+    || (CPU(X86) && OS(WINDOWS) && COMPILER(MINGW64) && GCC_VERSION >= 40100) \

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.