[Webkit-unassigned] [Bug 34971] New: check-webkit-style should report the number of files checked

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34971

           Summary: check-webkit-style should report the number of files
                    checked
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: hamaji at chromium.org
                CC: abarth at webkit.org, eseidel at chromium.org


Currently, check-webkit-style reports

  Total errors found: 0

when the check succeeded. This message isn't good because this message also
happens when no files are checked. For example, suppose there's a git commit
and no unstaged changes. If you run check-webkit-style without options, no
files will be checked. If you want to check the committed change, you need to
specify --git-commit=HEAD .

Reporting the number of files checked by the style checker would help to avoid
this kind of mistakes. With the patch I'll post, the style checker will report

  Total errors found: 0 in 0 files

We may be able to report more info, but this would be good as the start point.

I'm not sure if this change breaks WebKit buildbot (I guess it's OK because it
checks the exit status code?). Adam and Eric, could you check it?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.