[Webkit-unassigned] [Bug 34922] Mingw-w64 fixes for WebCore and JavaScriptCore

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34922





--- Comment #6 from vanboxem.ruben at gmail.com  2010-02-15 12:33:57 PST ---
The problem is, *if* mingw.org ever decides to bring out a 64-bit version, they
still have access to different functions, and use a different crt. For example,
in JavaScriptCore/runtime/Collector.cpp, mingw.org has its own implementation,
whereas mingw-w64 allows the msvc codepath to be taken. Also, for the mingw-w32
variant (also from the mingw-w64 team), which produces 32-bit binaries, the
given example will not compile, because some mingw.org functions
(Collector.cpp:line 324:__mingw_aligned_free and line 233
__mingw_aligned_malloc) are not implemented in mingw-w64/w32, because they have
the msvc functions. To see this difference, we either need a way to check
__MINGW64_VERSION_MAJOR (the only stable way to check for the difference),
which I implemented like so. I hope you understand the reasoning behind my
decision.

PS: I did not concatenate the CPU in the COMPILER check, mingw-w32 will also
register as COMPILER(MINGW64), because of the reason stated above.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.