[Webkit-unassigned] [Bug 34923] Incorrect client rects for blocks the span multiple columns and their descendants

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34923


Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #48732|review?                     |review+
               Flag|                            |




--- Comment #4 from Simon Fraser (smfr) <simon.fraser at apple.com>  2010-02-15 10:02:08 PST ---
(From update of attachment 48732)
> Index: WebCore/ChangeLog
> ===================================================================
> --- WebCore/ChangeLog	(revision 54757)
> +++ WebCore/ChangeLog	(working copy)
> @@ -1,3 +1,63 @@
> +2010-02-14  Dan Bernstein  <mitz at apple.com>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        <rdar://problem/7647300> Incorrect client rects for blocks the span multiple columns and their descendants
> +        https://bugs.webkit.org/show_bug.cgi?id=34923
> +

I'd like to see a summary of the problem, and your general approach at fixing
it here.

> +        (WebCore::SelectionController::layout): Pass the caret’s origin as the

Garbled curly quote.

> +        column offset to the computation, which previously this function didn’t

Ditto

> +        TransformState with the top left corner of the quad’s bounding box. It

And again

> Index: WebCore/rendering/RenderObject.h
> ===================================================================
> --- WebCore/rendering/RenderObject.h	(revision 54757)
> +++ WebCore/rendering/RenderObject.h	(working copy)
> @@ -563,7 +563,7 @@ public:
>      FloatQuad localToContainerQuad(const FloatQuad&, RenderBoxModelObject* repaintContainer, bool fixed = false) const;
>  
>      // Return the offset from the container() renderer (excluding transforms)
> -    virtual IntSize offsetFromContainer(RenderObject*) const;
> +    virtual IntSize offsetFromContainer(RenderObject*, const IntPoint&) const;

I'd like the comment to explain what the point is for.

> +    virtual void adjustForColumns(IntSize&, const IntPoint&) const { }

Also here. How is the IntSize being adjusted? What does the point represent?

r=me, with some addition commentary.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.