[Webkit-unassigned] [Bug 34881] [GStreamer] Notify about size changes

Mon Feb 15 09:50:25 PST 2010

https://bugs.webkit.org/show_bug.cgi?id=34881

Gustavo Noronha (kov) <gns at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #48640|review?                     |review-
               Flag|                            |

--- Comment #4 from Gustavo Noronha (kov) <gns at gnome.org>  2010-02-15 09:50:25 PST ---
(From update of attachment 48640)
 2  *  Copyright (C) 2009,2010 Sebastian DrÃ¶ge
<sebastian.droege at collabora.co.uk>

Add a space here (between the , and 2010 =))

 249     // than 20% of data. This allows us to need some time
 250     // to unpause the SoupMessage and not starve the pipeline
 251     // until it is finally unpaused.

I don't get this comment. What does 'allows us to need some time' mean? I
assume you want to say that you are raising the ammount of data that is
buffered before the message is paused, so that you lower the risk of delays in
unpausing starving the pipeline, right?

r- for the confusing comment, I believe the rest of the patch looks good, but
we need to get this comment straight.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.