[Webkit-unassigned] [Bug 16662] CSS3: Implement calc()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 15 06:12:45 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=16662





--- Comment #17 from Shinichiro Hamaji <hamaji at chromium.org>  2010-02-15 06:12:39 PST ---
> The changes to Length.h/cpp are layering violation.  The intent of the platform
> layer is that it has no knowledge of the classes such as those in the dom, css
> and rendering directories.  This violation needs to be fixed before going
> forward.

Thanks for your review! I updated my patch and we don't have dependencies from
platform/ to css/ anymore. I created a new file CalcValue.h/cpp. CalcValue is
created by CSSCalcValue with RenderStyle objects. RenderStyle objects are
necessary to resolve EMS and REMS. As EMS and REMS have been already resolved
in CalcValue, we don't need dependencies to CSS from this class.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list