[Webkit-unassigned] [Bug 34790] [Gtk] wrong video aspect ratio

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Feb 14 08:31:46 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=34790


Gustavo Noronha (kov) <gns at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #48633|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #9 from Gustavo Noronha (kov) <gns at gnome.org>  2010-02-14 08:31:46 PST ---
(From update of attachment 48633)
 47 gint greatestCommonDivisor(gint a, gint b);

You don't need to expose this function in the header. Just make it static, and
remove it from the .h (it's only used inside that file). Pay attention while
landing, you may need to use an svn checkout =(, I am not sure git svn will
handle the new binary file well. Thanks!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list