[Webkit-unassigned] [Bug 29177] [GTK] Right click does not activate text entry

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29177





--- Comment #5 from Gustavo Noronha (kov) <gns at gnome.org>  2010-02-14 08:21:45 PST ---
(From update of attachment 47962)
I very much like this patch, sorry for the delay in looking at it. I have a few
questions:

 235     if (mainFrame->view() &&
mainFrame->eventHandler()->handleMousePressEvent(event))
 236         mousePressEventResult = TRUE;

Why do we use the main frame here, instead of the focusedOrMainFrame?

285      if (!start.node() || !end.node())
 303     if (!start.node() || !end.node()
 304         || (page->mainFrame()->selection()->selection().isCaret() &&
!page->mainFrame()->selection()->selection().isContentEditable()))

Same here, will this still work for multi-frame pages, such as, say, the patch
review interface in this bugzilla? Thanks for digging the tests, that helps a
lot in keeping the sanity =).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.